Fix PHP CI including PHPCS and PHPUnit; bump PHP/WP versions

[westonruter]

Closes #983
Closes #1056

[codecov-commenter]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (62961cd) 19.65% compared to head (9fa812d) 29.34%.
Report is 17 commits behind head on develop.

Files	Patch %	Lines
...ponents/class-wp-service-worker-caching-routes.php	0.00%	4 Missing ⚠️
bin/verify-version-consistency.php	0.00%	2 Missing ⚠️
...ass-wp-service-worker-admin-assets-integration.php	0.00%	2 Missing ⚠️
...ss-wp-service-worker-custom-header-integration.php	0.00%	1 Missing ⚠️
wp-admin/admin.php	0.00%	1 Missing ⚠️
wp-includes/general-template.php	0.00%	1 Missing ⚠️
wp-includes/template.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #1095      +/-   ##
=============================================
+ Coverage      19.65%   29.34%   +9.69%     
+ Complexity       347      334      -13     
=============================================
  Files             57       57              
  Lines           2325     1690     -635     
=============================================
+ Hits             457      496      +39     
+ Misses          1868     1194     -674     

Flag	Coverage Δ
php	29.34% <20.00%> (+9.69%)	⬆️
unit	29.34% <20.00%> (+9.69%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thelovekesh]

Need to emulate it to 7.0 else it can download deps that don't support PHP 7.0.

[westonruter]

Humm. I had updated the composer.lock file for PHP 8.0 so we'll need to update it for 7.0. However, when I do so then I get errors when running tests locally:

$ npm run test:php

> test:php
> wp-env run tests-cli --env-cwd=/var/www/html/wp-content/plugins/pwa/ env WORDPRESS_TABLE_PREFIX=wptests_ vendor/bin/phpunit

ℹ Starting 'env WORDPRESS_TABLE_PREFIX=wptests_ vendor/bin/phpunit' on the tests-cli container. 

[18-Jan-2024 22:34:19 UTC] PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /var/www/html/wp-content/plugins/pwa/vendor/phpunit/phpunit/src/Util/Configuration.php on line 176
[18-Jan-2024 22:34:19 UTC] PHP Fatal error:  Cannot acquire reference to $GLOBALS in /var/www/html/wp-content/plugins/pwa/vendor/phpunit/phpunit/src/Util/Configuration.php on line 543
✖ Command failed with exit code 255

If I change it to 7.4 and run composer update then I can run PHPUnit successfully, even when I'm running PHP 8.1.

Can we change this then to (and run composer update):

Suggested change

	"php": "7.0"
	"php": "7.4"

If that means removing tests for PHP 7.0-7.3, I'm fine with that.

[thelovekesh]

It's because the PHPUnit version is not compatible with the PHP version inside the container. So I think we need to use updated PHPUnit for local testing.

So we have two options now:

• We save PHPUnit 9.6 PHAR in bin like we do for PHPStan and keep 7.0 tests.
• Remove 7.0 tests and bump PHP emulation to 7.1.

[thelovekesh]

Now PHPUnit version is customizable in local development with - 9fa812d

With this, we can download any PHPUnit version and keep the tests for PHP 7.0.

[westonruter]

Clever!