Skip to content

Missleading naming "run*" #4

Open

Description

@bwaidelich

I got confused by the names of the two run* commands because I expected them to, well, run the tasks but in fact even ./flow task:runSingle only schedules a task – or even doesn't do anything if one is scheduled already.

(PS: I copied the naming to my TaskModule package which makes it even more confusing)

Suggestion

I propose to deprecate the two commands task:run and task:runSingle in favor of a new command task:schedule (or similar) with an optional filter to schedule tasks by id etc.
(task:run and task:runSingle should still work of course for B/C but they would be hidden from ./flow help)

Additionally I could imagine another command task:execute that allows to immediately run a task whether it is scheduled or not.

@daniellienert I could take care of this suggestion, but would like to hear your opinion on it, first

Activity

  1. daniellienert commented on Feb 22, 2022

    @daniellienert
    Contributor

    Hey @bwaidelich,

    Yeah absolutely!

    I'am fine with the renaming and I would absolutely like to have a better solution for runSingle which directly executes the task. I already searched for an elegant solution but did not find any and feedback in general to the module was rare. I love to see you using the package. If you like to discuss other things and concepts, just ping me.

  2. bwaidelich commented on Jul 15, 2022

    @bwaidelich
    ContributorAuthor

    Update: Unfortunately the undertaking turned out to be more complex than I had anticipated.. Right now I miss the personal itch (or task) to take care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions