Remove "$targetWorkspaceName" from indexer -- as that's a very crude hack #45

Activity

1. dfeyer commented on Aug 5, 2016

   

   dfeyer

   on Aug 5, 2016

   Contributor

   More actions

   @bwaidelich Is this issue always a problem ? And if it's the case, can push a PR to solve it ?
2. dfeyer

   added

   I: Discussion‌‌

   T: PHP

   T: Bug

   T: Enhancement

   on Aug 5, 2016
3. bwaidelich commented on Aug 6, 2016

   

   bwaidelich

   on Aug 6, 2016

   Contributor

   More actions

   @dfeyer wrong (se)bastian ;)

   🎉React with 🎉1Reacted by Dominique Feyer
4. dfeyer commented on Aug 6, 2016

   

   dfeyer

   on Aug 6, 2016

   Contributor

   More actions

   @skurfuerst Ping, is this issue fixed now or did we need to tackle it ?
5. dfeyer commented on Oct 5, 2016

   

   dfeyer

   on Oct 5, 2016

   Contributor

   More actions

   @skurfuerst Ping again, this is quiet old issue, but not sure if it affect the current implementation ?
6. skurfuerst commented on Oct 17, 2016

   

   skurfuerst

   on Oct 17, 2016

   Last edited by kdambekalns

   ContributorAuthor

   More actions

   Hey Dominique,

   this is still relevant I think:

   Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Flowpack/ElasticSearch/ContentRepositoryAdaptor/Indexer/NodeIndexer.php

   Line 144 in a092e41

   public function indexNode(NodeInterface $node, $targetWorkspaceName = null)

   All the best,
   Sebastian
7. kdambekalns commented on Jun 2, 2017

   

   kdambekalns

   on Jun 2, 2017

   Last edited by kdambekalns

   Member

   More actions

   Also the current version that string manipulation is still done:

   • Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Indexer/NodeIndexer.php

     Line 264 in 070fded

     $contextPath = str_replace($node->getContext()->getWorkspace()->getName(), $targetWorkspaceName, $contextPath);

   And in three more places:

   • Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Indexer/NodeIndexer.php

     Line 181 in 070fded

     $contextPath = str_replace($node->getContext()->getWorkspace()->getName(), $targetWorkspaceName, $contextPath);

   • Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Driver/Version1/IndexerDriver.php

     Line 93 in 070fded

     $closestFulltextNodeContextPath = str_replace($node->getContext()->getWorkspace()->getName(), $targetWorkspaceName, $closestFulltextNodeContextPath);

   • Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Driver/Version2/IndexerDriver.php

     Line 95 in 070fded

     $closestFulltextNodeContextPath = str_replace($node->getContext()->getWorkspace()->getName(), $targetWorkspaceName, $closestFulltextNodeContextPath);

   These should (re-)use calculateDocumentIdentifier() as defined in

   Flowpack.ElasticSearch.ContentRepositoryAdaptor/Classes/Indexer/NodeIndexer.php

   Line 259 in 070fded

   protected function calculateDocumentIdentifier(NodeInterface $node, $targetWorkspaceName = null)

   !
8. dfeyer commented on Apr 7, 2019

   

   dfeyer

   on Apr 7, 2019

   Contributor

   More actions

   @kdambekalns Code duplication is remove here 2e04e1f