Skip to content

fix: disable udp/tcp listener if port is set to 0 - #457

Open
Zxilly wants to merge 1 commit into
AdguardTeam:masterfrom
ZxillyFork:master
Open

Zxilly wants to merge 1 commit into
AdguardTeam:masterfrom
ZxillyFork:master

Conversation

@Zxilly

@Zxilly Zxilly commented May 27, 2025

Copy link
Copy Markdown

According to the documentation, setting the port to 0 should disable plain DNS handler (TCP/UDP), but the current implementation just starts the corresponding DNS on a random port, and this patch makes the program consistent with the documentation.

@windsurf-bot windsurf-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

@Zxilly

Zxilly commented Jun 1, 2025 •

Copy link
Copy Markdown
Author

@schzhn @EugeneOne1 Hi, can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant