Fix: Use 'ep_' . $indexable->slug . '_sync_kill' to prevent indexing the object#4282
Open
burhandodhy wants to merge 7 commits intodevelopfrom
Open
Fix: Use 'ep_' . $indexable->slug . '_sync_kill' to prevent indexing the object#4282burhandodhy wants to merge 7 commits intodevelopfrom
burhandodhy wants to merge 7 commits intodevelopfrom
Conversation
burhandodhy
force-pushed
the
fix/4278
branch
from
5a8e526 to
aaee659
Compare
felipeelia
requested changes
Feb 17, 2026
| * @param int $object_id The object ID | ||
| * @return null|bool | ||
| */ | ||
| public function sync_password_protected_orders( $new_skip, bool $skip, $object_id ) { |
Member
There was a problem hiding this comment.
@burhandodhy let's avoid forcing types on methods hooked into actions and filters, as this has caused us some problems lately. We can certainly cast it to bool on return though.
felipeelia
requested changes
Feb 20, 2026
Co-authored-by: Felipe Elia <felipe.elia@fueled.com>
Co-authored-by: Felipe Elia <felipe.elia@fueled.com>
Co-authored-by: Felipe Elia <felipe.elia@fueled.com>
Co-authored-by: Felipe Elia <felipe.elia@fueled.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR ensures that using
ep_' . $indexable->slug . '_sync_killis sufficient to prevent the object from being indexed, either through sync or post update.Closes #4278
How to test the Change
Changelog Entry
Credits
Props @burhandodhy @felipeelia @matthijsch
Checklist: