Refresh features on save

[ZacharyRener]

Description of the Change

The purpose with this PR is to refresh the feature settings and settings schema on save, instead of requiring a refresh, universally.

For SemanticSearch in particular, EP Labs needs an update to actually consider whether the feature is active before adding the algorithms: 10up/ElasticPressLabs#184

For testing, see 10up/ElasticPressLabs#184

You can also reference the feature interface e2e test added here which has a simulated version of this

Closes #4267

How to test the Change

• Enable Semantic Search
• Enable a semantic search algorithm version
• Save settings
• Go to Instant Results
• Confirm it is now showing as disabled without refreshing the page

Changelog Entry

Changed - Saving feature settings will now reflect feature dependency without refreshing the page

Credits

Props @ZacharyRener

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added Critical Flows, Test Cases, and/or End-to-End Tests to cover my change.
• All new and existing tests pass.

[felipeelia]

@ZacharyRener any chance we can add some e2e tests for this one? Enabling Did you mean should make an option in Instant Results editable, for example.

[ZacharyRener]

@felipeelia The staleness issue happens when the TEMPORARILY_DISABLED status is passed (or similar server side check), because those server side checks weren't applying until page refresh. The did you mean / instant results example you already doesn't go stale because it's just an interface check

EP labs example

So I setup a test plugin here to simulate the conflict and added an e2e test

I'll move this to review once the tests are all passing but just fyi.

[ZacharyRener]

The purpose with this PR now is to refresh the feature settings and settings schema on save, instead of requiring a refresh, universally. The test here was updated to be a more generic replication of the issue instead of the temporarily_disabled check from earlier.

For SemanticSearch in particular, EP Labs needs an update to actually consider whether the feature is active before adding the algorithms: 10up/ElasticPressLabs#184