Get WordPress

Make WordPress Core

Opened 14 hours ago

Last modified 8 hours ago

#64792 new enhancement

Consider changing code tags to regular text for dimension values in "Site Icon" help text

Reported by: juanfra's profile juanfra Owned by:
Milestone: 7.1 Priority: normal
Severity: normal Version: 6.5
Component: Administration Keywords: needs-patch good-first-bug
Focuses: Cc:

Description

The Site Icon help text uses <code> tags around dimension values, which is probably not needed given the context.

This shows up in two places (​one and ​two). The dimensions are just regular measurements in help text, so they don't need the monospace treatment.

I'd propose to wrap them in <strong> if the objective is to add prominence. Or avoid any markup at all if we don't want to be really highlighting these values.

Change History (2)

#1 @sabernhardt
13 hours ago

  • Component changed from Text Changes to Administration
  • Keywords 2nd-opinion added
  • Type changed from defect (bug) to enhancement
  • Version set to 6.5

[57713] replaced strong tags with code, though that was before [58927] replaced &times; with 'by'.

#2 @SergeyBiryukov
8 hours ago

  • Keywords needs-patch good-first-bug added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 7.1

Thanks for the ticket! I think these can be changed back to <strong> now that &times; has been replaced with 'by' (as noted above).

Note: See TracTickets for help on using tickets.