Admin reskin: Remove line-height from input elements

[wildworks]

The line-height of the input element has a value of 2.71428571 applied to it, making it equal to a height of 40px. This value also seems to affect the height of the background highlight when text is selected. At least, this behavior can be confirmed on Windows OS and Chrome browsers.

I don't know why this line-height value exists, but it's strange to have a highlight background that extends to the full height of the form.

[wildworks]

The background when text in an input element is selected. Comparison of the current style and my proposed style.

[audrasjb]

Adding good-first-bug keyword as this issue would be a nice bug to fix for new contributors who never submitted any Core patch yet.

[wildworks]

@fabiankaegy @joedolson Is there any reason why a line-height value equal to min-height is being applied to form elements? Would simply removing the line-height cause any problems?

Remove line-height property from URL and week input styles.

Trac ticket: https://core.trac.wordpress.org/ticket/64763

## Use of AI Tools

Could you please add the ticket URL to the PR description?

Thanks! I’ve added the ticket URL to the PR description.

[manhar]

Tested the patch on trunk.

Removing the line-height keeps the 40px height via min-height and improves text alignment/selection. No visual regressions found in admin screen.

Before Patch:
​https://postimg.cc/FYXV0Hb0

After Patch:
​https://postimg.cc/yJQRp19N

Thanks for the PR!

It applies nicely to standard inputs:

However it doesn't apply to input fields using "compact" styles:

[ozgursar]

Patch Testing Report

Patch Tested: ​https://github.com/WordPress/wordpress-develop/pull/11099

Environment

• WordPress: 7.0-beta2-61752-src
• PHP: 8.2.29
• Server: nginx/1.29.4
• Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
• Browser: Chrome 145.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.4
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.1

Steps taken

1. Check an input field in Settings > General
2. ✅ Patch is solving the problem

Expected result

• Line height is removed from input elements

Screenshots/Screencast with results

Before

After

## Description
Removes the line-height: 2.71428571 declaration from standard admin input elements. Height remains 40px via min-height; only the line-height is removed.

## Changes

• File: src/wp-admin/css/forms.css
• Removed one line-height line from the rule that targets input[type="datetime"] through input[type="week"] (and related types).

## Testing

• Checked inputs on Settings → General and other admin forms.
• Confirmed input height unchanged (40px) and selection highlight no longer fills the full field.

Trac: https://core.trac.wordpress.org/ticket/64763

Fixes #64763

Thanks for the PR.
I noticed there is already an older PR (#11099) for the same issue and it has been reviewed by a committer. Maybe it would be better to continue contributing there instead of opening a new PR.

@huzaifaalmesbah Thanks for review. okay noted

[noruzzaman]

Test Report

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/11099

Environment

• WordPress: 7.0-beta2-61809
• PHP: 8.3.30
• Server: PHP.wasm
• Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
• Browser: Chrome 145.0.0.0
• OS: macOS
• Theme: Twenty Fourteen 4.4
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.1

Actual Results

1. ✅ Issue resolved with patch.

Before	After

I’m closing this PR to focus on ​https://github.com/WordPress/wordpress-develop/pull/11099.

[wildworks]

Thankyou everyone for working on this ticket.

However it doesn't apply to input fields using "compact" styles:

As mentioned here, there's probably more than one thing that needs to be fixed. Let's try to investigate as much as possible where this problem is occurring.