/html

Remove <label form> and redefine label.form IDL attribute #1120

Merged
merged 4 commits into from Apr 28, 2016

3 participants

@zcorpan @annevk @domenic
@zcorpan
Owner
zcorpan commented Apr 25, 2016

This implements #787 (comment)

Separated into several commits for easier reviewing.
@annevk annevk commented on an outdated diff Apr 25, 2016
View full outdated diff
source
+ <hr>
+
+ <dl class="domintro">
+
+ <dt><var>label</var> . <code subdfn data-x="dom-label-form">form</code></dt>
+
+ <dd>
+
+ <p>Returns the <span>form owner</span> of the form control that is associated with this
+ element.</p>
+
+ <p>Returns null if there isn't one.</p>
+
+ </dd>
+
+ </dl>
annevk
annevk Apr 25, 2016 Owner

Should this perhaps be higher up? Usually the domintro is before we describe any IDL attributes.
@annevk
Owner
annevk commented Apr 25, 2016

LGTM, should we wait for two implementer commitments?
@zcorpan zcorpan referenced this pull request in w3c/web-platform-tests Apr 28, 2016
Closed

Write tests for <label form> removal spec change #2924

@zcorpan
Owner
zcorpan commented Apr 28, 2016

Seems like we can go ahead with this. Need tests though, w3c/web-platform-tests#2924
@zcorpan zcorpan merged commit 99f0f1a into master Apr 28, 2016
@zcorpan zcorpan deleted the remove-label-form branch Apr 28, 2016
@zcorpan zcorpan added a commit to w3c/web-platform-tests that referenced this pull request Apr 29, 2016
@zcorpan zcorpan Fix #2924: Update tests for <label form> removal spec change 
This tests whatwg/html#1120.
 5e154a7
This was referenced Apr 29, 2016
Merged
Closed
@zcorpan zcorpan added a commit to w3c/web-platform-tests that referenced this pull request May 13, 2016
@zcorpan zcorpan Fix #2924: Update tests for <label form> removal spec change (#2926) 
This tests whatwg/html#1120.
 0f1a6ff
@arronei arronei added a commit to arronei/web-platform-tests that referenced this pull request Jun 14, 2016
@zcorpan @arronei zcorpan + arronei Fix #2924: Update tests for <label form> removal spec change (#2926) 
This tests whatwg/html#1120.
 b9f2b64
@ivanzr ivanzr added a commit to ivanzr/web-platform-tests that referenced this pull request Jun 29, 2016
@zcorpan @ivanzr zcorpan + ivanzr Fix #2924: Update tests for <label form> removal spec change (#2926) 
This tests whatwg/html#1120.
 a6698d3
@cscott cscott added a commit to fgnass/domino that referenced this pull request Oct 14, 2016
@cscott cscott `label form` has been removed. 
This fixes a test case which was broken by
c8fbfff.

The upstream removal of the form attribute for <label> was
whatwg/html#787, pulled in
whatwg/html#1120, and implemented in
browsers as whatwg/html#787 (comment).
 9ed8d4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment