timruffles
Member since
Recent Docs Activity
View all activity| Page | Date | Comment |
|---|---|---|
Element.classList |
Make example self-contained, use const where appropriate, and possible to copy-paste and run in the browser console. | |
IDBObjectStore.put() |
||
Using IndexedDB |
Iterating arrays with `for ... in` is error prone and non-idiomatic. Switched to ES5 forEach to match majority of rest of code, which is written in ES5. | |
ServiceWorkerGlobalScope |
Having an explicit 'catch' here will cause issues when people copy the code. Whereas the comment suggests the catch will only handle fetch errors, as written it actually handles both fetch errors and errors from the success mapper (then arg above). |