Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upNobug : Adds eslint and husky for linting goodness #4199
Conversation
schalkneethling
requested a review
from
stephaniehobson
Apr 26, 2017
schalkneethling
reviewed
Apr 26, 2017
| "browser": true, | ||
| "es6": true, | ||
| "jquery": true, | ||
| "jasmine": true |
This comment has been minimized.
This comment has been minimized.
schalkneethling
Apr 26, 2017
Author
Collaborator
We may not need jasmine here, not sure what MDN uses for JS tests.
This comment has been minimized.
This comment has been minimized.
stephaniehobson
Apr 27, 2017
Contributor
We don't have any JS tests right now. We will probably use jasmine if/when we do to be inline with bedrock but it should be removed for now.
schalkneethling
reviewed
Apr 26, 2017
| "gettext": true, | ||
| "interpolate": true, | ||
| "mdn": true, | ||
| "Mozilla": true |
This comment has been minimized.
This comment has been minimized.
schalkneethling
Apr 26, 2017
Author
Collaborator
Also, not sure if we need all of these as globals, added them as they came up but, with some of the exclusions I then introduced, perhaps they are not all needed.
This comment has been minimized.
This comment has been minimized.
stephaniehobson
Apr 27, 2017
Contributor
We also need to add waffle. Nothing jumps out at me from that last as something we can remove if we're not linting the libraries.
stephaniehobson
requested changes
Apr 27, 2017
|
Works great locally. OMG we have so much work to do +1 without Jasmine and ES6 |
| "gettext": true, | ||
| "interpolate": true, | ||
| "mdn": true, | ||
| "Mozilla": true |
This comment has been minimized.
This comment has been minimized.
stephaniehobson
Apr 27, 2017
Contributor
We also need to add waffle. Nothing jumps out at me from that last as something we can remove if we're not linting the libraries.
| module.exports = { | ||
| "env": { | ||
| "browser": true, | ||
| "es6": true, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Apr 28, 2017
Codecov Report
@@ Coverage Diff @@
## master #4199 +/- ##
==========================================
- Coverage 86.25% 86.25% -0.01%
==========================================
Files 146 147 +1
Lines 9035 9040 +5
Branches 1211 1211
==========================================
+ Hits 7793 7797 +4
Misses 1004 1004
- Partials 238 239 +1
Continue to review full report at Codecov.
|
schalkneethling commentedApr 26, 2017
Hey @stephaniehobson
This adds
eslintto the project. If you use aneslintlinter plugin for your editor, you should get real time linting feedback. There is also a lint target with:npm run lintI have marked most things as warnings so, the pre-commit hook introduced here will pass for the moment.