Repository navigation
Include tests in the source distribution - #424
Merged
Merged
Conversation
The repository already ships certifi/tests, but MANIFEST.in only listed package data files, so sdist builds omitted the suite. Add a recursive-include so downstream can test from the sdist. Closes #226 Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
certifi/testsalready lives in the repository, butMANIFEST.inonly listed package data files (cacert.pem,py.typed, etc.). Source distributions therefore shipped without the test suite, which makes downstream sdist testing harder (#226).Changes
recursive-include certifi/tests *so the suite is packaged in the sdist.global-exclude *.py[cod] __pycache__ .DS_Storeso local bytecode is not pulled into the archive when tests are included.Test plan
python3 setup.py sdist— archive listscertifi/tests/__init__.pyandcertifi/tests/test_certify.py, no__pycache__.PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python3 -W error -m pytest -qfrom git tree: 3 passed.python3 -m unittest discover -s certifi/tests -vfrom extracted sdist: 3 OK.Closes #226