Skip to content

Added support for special characters - #60

Merged
theskumar merged 1 commit into
theskumar:masterfrom
pjona:special_characters
Aug 9, 2017
Merged

theskumar merged 1 commit into
theskumar:masterfrom
pjona:special_characters

Conversation

@pjona

@pjona pjona commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

Without this changes the new test that I added fail. So for example, you have in your .env password with special characters:

PASSWORD="}=&~{,(\5%{&;"

But using package it return: }=&~{,(%{&; (Missing \5)

@coveralls

coveralls commented Aug 8, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 82.418% when pulling fa66e0b on pjona:special_characters into 77dc37d on theskumar:master.

@pjona

pjona commented Aug 8, 2017

Copy link
Copy Markdown
Contributor Author

I checked also PHP version of dotenv idea (https://github.com/vlucas/phpdotenv) and they handle it correctly.

@theskumar

Copy link
Copy Markdown
Owner

Thanks @pjona for the pull-request, i'll test and merge it soon!

@theskumar
theskumar merged commit b7c6d1b into theskumar:master Aug 9, 2017
@theskumar

Copy link
Copy Markdown
Owner

Thanks a lot for contributing. This will be available in next release.

@theskumar

theskumar commented Aug 9, 2017 •

Copy link
Copy Markdown
Owner

python-dotenv==0.6.5 released. 🎉

@alanjds

alanjds commented Jan 15, 2018

Copy link
Copy Markdown
Contributor

People around me got some trouble w/ accents on right side of the =. Got working after reversing this patch.

What am I doing wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants