[6.x] Augment nav blueprint fields onto manual-URL nav items - #15235
Merged
jasonvarga merged 1 commit intoAug 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields defined on a navigation blueprint only reach nav items that reference an entry. A manual-URL item, including a manual-URL child under an entry-backed parent, falls back to a hardcoded key list, so Antlers resolves the missing key against the enclosing scope instead of the item's own value. In practice a manual-URL child silently inherits its parent's field value.
AugmentedPage::keys()only mergesblueprintFields()->keys()throughparent::keys(), which only runs when the page has an entry.blueprintFields()already resolves the right blueprint for both entry and non-entry pages, it just wasn't merged into the key list on the non-entry branch.This merges
blueprintFields()->keys()into the key list unconditionally, so manual-URL items report their own blueprint field values instead of the parent's.Fixes #15233