[6.x] Revert throw on mixed pipe/shorthand modifier syntax - #15073
Merged
jasonvarga merged 3 commits intoAug 4, 2026
Merged
Conversation
Reproduces the case reported in statamic#14892 (comment) — a standalone (non-paired) tag mixing pipe and shorthand modifier syntax used to render fine, but now throws a parser error.
…ier syntax (statamic#14892)" This reverts commit 6a81472.
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#14892 added a parser error whenever a tag has both a pipe modifier (
|) and a shorthandkey=valueparameter present, intending to catch the tag-pair mixing case from #13080 ({{ x | mod="value" }} ... {{ /x }}, which silently rendered empty).However the check fires on any node with both, not just tag pairs — including standalone tags that previously rendered correctly, e.g.:
{{ last_modified | format="U" }}Reported in #14892 (comment). Verified by reverting the parser change locally and rendering the above against a real date — it produces the correct Unix timestamp, confirming this was working, not "silently failing."
This PR reverts #14892 on
6.xand adds a regression test for the standalone case. A follow-up tracking issue covers reintroducing the throw as a breaking change in the next major version.Test plan
test_pipe_with_shorthand_modifier_parameter_on_standalone_tag_still_rendersadded — fails against pre-revert code, passes after revertCoreModifiersTestandParserErrorsTestsuites pass