[5.x] Fix Stache index re-entrancy causing null URIs on cold stache - #14181
Merged
Conversation
Contributor
|
I'm waiting for this one :) @o1y Can you push a empty commit to trigger the pipeline again? |
o1y
force-pushed
the
fix-stache-null-uris-5.x
branch
from
March 18, 2026 09:41
ecfe1b8 to
6783297
Compare
Contributor
|
Thanks! Now lets wait for the next 5.x release. Meanwhile i will use this fix via composer patch. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
No internal callers remain after switching to Index::isLoading(). Kept for potential addon usage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wrap Index::load() body in try/finally so the static loading stack is always cleaned up, even if an exception is thrown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14109 to 5.x.
Fixes statamic/seo-pro#508