Skip to content

Commit b247a9d

Browse files
authored
fix(linter/unicorn/new-for-builtins): support Float16Array (#25382)
## Summary - Add `Float16Array` to the list of builtins enforced by `unicorn/new-for-builtins` - Uncomment the corresponding test case - Update the rule's documentation to mention `Float16Array` ## References - https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/test/snapshots/new-for-builtins.js.md#invalid47-const-foo--float16array
1 parent 19109cd commit b247a9d

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎crates/oxc_linter/src/rules/unicorn/new_for_builtins.rs‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ declare_oxc_lint!(
2525
/// ### What it does
2626
///
2727
/// Enforces the use of `new` for the following builtins: `Object`, `Array`, `ArrayBuffer`, `BigInt64Array`,
28-
/// `BigUint64Array`, `DataView`, `Date`, `Error`, `Float32Array`, `Float64Array`, `Function`, `Int8Array`,
28+
/// `BigUint64Array`, `DataView`, `Date`, `Error`, `Float16Array`, `Float32Array`, `Float64Array`, `Function`, `Int8Array`,
2929
/// `Int16Array`, `Int32Array`, `Map`, `WeakMap`, `Set`, `WeakSet`, `Promise`, `RegExp`, `Uint8Array`,
3030
/// `Uint16Array`, `Uint32Array`, `Uint8ClampedArray`, `SharedArrayBuffer`, `Proxy`, `WeakRef`, `FinalizationRegistry`.
3131
///
@@ -139,6 +139,7 @@ const ENFORCE_NEW_FOR_BUILTINS: phf::Set<&'static str> = phf::phf_set![
139139
"Date",
140140
"Error",
141141
"FinalizationRegistry",
142+
"Float16Array",
142143
"Float32Array",
143144
"Float64Array",
144145
"Function",
@@ -294,7 +295,7 @@ fn test() {
294295
"const foo = DataView()",
295296
"const foo = Error()",
296297
"const foo = Error('Foo bar')",
297-
// "const foo = Float16Array()",
298+
"const foo = Float16Array()",
298299
"const foo = Float32Array()",
299300
"const foo = Float64Array()",
300301
"const foo = Function()",

‎crates/oxc_linter/src/snapshots/unicorn_new_for_builtins.snap‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,12 @@ source: crates/oxc_linter/src/tester.rs
186186
· ────────────────
187187
╰────
188188

189+
unicorn(new-for-builtins): Use `new Float16Array()` instead of `Float16Array()`
190+
╭─[new_for_builtins.tsx:1:13]
191+
1const foo = Float16Array()
192+
· ──────────────
193+
╰────
194+
189195
unicorn(new-for-builtins): Use `new Float32Array()` instead of `Float32Array()`
190196
╭─[new_for_builtins.tsx:1:13]
191197
1const foo = Float32Array()

0 commit comments

Comments
 (0)