Skip to content

docs: clarify authentication for static routes - #12742

Closed
Mr-KnightCLI wants to merge 1 commit into
meta:mainfrom
Mr-KnightCLI:docs-auth-protect-static-routes
Closed

Mr-KnightCLI wants to merge 1 commit into
meta:mainfrom
Mr-KnightCLI:docs-auth-protect-static-routes

Conversation

@Mr-KnightCLI

@Mr-KnightCLI Mr-KnightCLI commented Oct 19, 2026 •

Copy link
Copy Markdown

Motivation

Clarifies that Docusaurus generates static HTML and assets, so a client-side route guard does not enforce access control for private content. Relates to #6890.

Changes

  • Explain that Docusaurus does not provide per-route server-side session checks.
  • Recommend enforcing access at the hosting layer or through a backend that authorizes requests.
  • Clarify that client-side guards are for presentation/navigation, not protecting confidential content.

Test Plan

Documentation-only change. Manually reviewed the new guidance against the existing explanation that routes are emitted as static HTML. No automated tests or site build were run.

Test links

  • website/docs/advanced/routing.mdx

Related issues/PRs

Summary by CodeRabbit

  • Documentation
    • Added guidance on authentication and access control, clarifying the limits of client-side route guards and where confidential content access should be enforced.
@meta-cla

meta-cla Bot commented Oct 19, 2026

Copy link
Copy Markdown

Hi @Aoi-Todoo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Oct 19, 2026

Copy link
Copy Markdown

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9b0f608
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6ad6592a10b13ea80526464b
😎 Deploy Preview https://deploy-preview-12742--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f317ee9-6cda-4bcd-bb4b-f91f5ac57e15
📥 Commits

Reviewing files that changed from the base of the PR and between 7b6826b and 9b0f608.

📒 Files selected for processing: 1
  • website/docs/advanced/routing.mdx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The routing guide now explains that Docusaurus generates static HTML and assets at build time. It distinguishes client-side route guards from access controls enforced by a hosting layer or a backend.

Changes: Routing access-control guidance

Layer / File(s) Summary
Document static content access limits
website/docs/advanced/routing.mdx
The guide explains that generated HTML and assets can be requested directly, and that client-side guards do not protect confidential content. It describes hosting-layer authorization or backend request checks as access-control options.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9b0f6

This documentation-only change accurately explains that confidential static content needs protection at the hosting layer or through a backend; no actionable merge risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the documentation change about authentication for static routes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@meta-cla

meta-cla Bot commented Oct 19, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Oct 19, 2026
@slorber slorber closed this Oct 19, 2026
@slorber slorber reopened this Oct 19, 2026
@slorber slorber closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

2 participants