Skip to content

Reject async shared context functions - #382

Open
Mr-KnightCLI wants to merge 2 commits into
meta:mainfrom
Mr-KnightCLI:fix-reject-async-shared-context
Open

Reject async shared context functions#382
Mr-KnightCLI wants to merge 2 commits into
meta:mainfrom
Mr-KnightCLI:fix-reject-async-shared-context

Conversation

@Mr-KnightCLI

@Mr-KnightCLI Mr-KnightCLI commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

What: Rejects async functions passed as shared contexts. Fixes #143.

Why: Shared contexts should follow the same synchronous-context rule as regular contexts.

How: Applies the existing async-function validation to shared contexts and adds regression tests for async nested and shared contexts.

Risks: Low; validation-only change.

Validation:

  • python -m py_compile testslide/bdd/dsl.py tests/dsl_unittest.py passed.
  • git diff --check passed.
  • Focused unit tests could not run because downloading the typeguard dependency stalled.

Checklist:

  • Added tests
  • Updated documentation N/A
  • Ensured the test suite passes (focused test blocked by dependency download)
  • Made sure your code lints (not run)
  • Completed the Contributor License Agreement (previously signed)
@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

1 participant

@Mr-KnightCLI