Skip to content

[WIP] fix: cover page button style - #670

Closed
cheng-kang wants to merge 1 commit into
masterfrom
fix/665
Closed

cheng-kang wants to merge 1 commit into
masterfrom
fix/665

Conversation

@cheng-kang

Copy link
Copy Markdown
Contributor

Closes #665

Issue

CSS selector for cover page buttons are not working due to change of marked output. No <p> wrapper anymore.

Solution

Update CSS selector solves the problem.

Discussion

Although updating CSS selector solves the problem, it brings a potential issue: all direct child <a> tags of .cover-main will now be rendered as a "cover page button".

Another way of solving this might be adding a new wrapper to buttons, or add configs ([GitHub](https://github.com/docsify :cover-page-button)) to links to declare that they should be styled as "cover page buttons".

@QingWei-Li what's your opinion?


Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.
@cheng-kang
cheng-kang requested a review from QingWei-Li October 31, 2018 23:13
@QingWei-Li

Copy link
Copy Markdown
Member

We should parse markdown use #lexel.
This makes it easier and safer to render cover.

@QingWei-Li

Copy link
Copy Markdown
Member

A temporary solution: find brother elements...

.cover-main
 &>blockquote~a,
 &>ul~a,
 &>h1~a
   ...
QingWei-Li added a commit that referenced this pull request Nov 1, 2018
@QingWei-Li QingWei-Li closed this in fcd1087 Nov 1, 2018
@cheng-kang
cheng-kang deleted the fix/665 branch November 1, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants