Repository navigation
fix(external-script): preserve HTML attributes - #2819
Merged
sy-records merged 2 commits intoOct 21, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
sy-records
force-pushed
the
fix/external-script-attributes
branch
from
October 16, 2026 03:59
de19ed0 to
9849872
Compare
trusktr
approved these changes
Oct 21, 2026
Member
|
@sy-records what happened to the original author? I'm confused: 
|
Member
|
Maybe it's using Ai, but the configuration is wrong. My commit is because of rebase. |
sy-records
approved these changes
Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External scripts recreated by the external-script plugin lose HTML attributes such as
data-message,crossorigin, andreferrerpolicy. AssigningnewScript[attribute.name]creates unrelated JavaScript properties for names that do not match DOM properties, so widgets lose configuration and browser request settings.Copy attributes with
setAttribute(). The browser regression executes a local script and readsdocument.currentScript.dataset,crossOrigin, andreferrerPolicyfrom the actual replacement element.Example:
<script src="/widget.js" data-message="hello" crossorigin="anonymous" referrerpolicy="no-referrer"></script>now retains all three settings when executed by the plugin.Related issue, if any:
Reproduced on develop at
d823dbe51c1b2dea4c2091e2b952ded0d1e16616; no matching open fix found.What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Validation
undefined,null, and an empty string instead of the configured attribute values.npm run test:e2e:chromium -- test/e2e/plugins.test.js --workers=1 --reporter=line: 9 tests passed, including the regression.npm run test:jest -- --runInBand: 128 tests and 46 snapshots passed.npm run build,npm run lint,npm run typecheck, andgit diff --check: passed.Browser coverage: Chromium via Playwright; Firefox, WebKit, and unrelated E2E suites were not run locally.
Developed with assistance from OpenAI Codex; regression and fix validated locally.