Skip to content

fix: enhance focus handling - #2595

Merged
sy-records merged 2 commits into
docsifyjs:developfrom
sy-records:fix/focus
Aug 21, 2025
Merged

sy-records merged 2 commits into
docsifyjs:developfrom
sy-records:fix/focus

Conversation

@sy-records

Copy link
Copy Markdown
Member

Summary

Related issue, if any:

Fix #2594
Fix #2569

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
@vercel

vercel Bot commented Aug 8, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
docsify-preview ✅ Ready Preview Comment Aug 13, 2025 10:10am

@paulhibbitts paulhibbitts left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @sy-records , from a UX perspective this looks fantastic!

I've run some additional tests, here is the initial code sandbox now using your PR build:
https://codesandbox.io/p/sandbox/docsify-v5-rc-1-coverpage-jx2rl3

The coverpage title link now scrolls to the expected location. To help ensure this PR did not introduce other side-effects, I also updated the earlier HTML Anchor test with your PR build and all looks good there too:
https://paulhibbitts.github.io/docsify-v5-anchors-test/#/anchors-test

And finally I updated the earlier GitHub Pages test with your PR build and all looks good there as well:
https://paulhibbitts.github.io/docsify-v5-preview-coverpage/

The next RC is looking to be really really good 🙂

This branch was successfully deployed

1 active deployment
Preview — 032c4cfc Deployed Aug 13, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants