Skip to content

feat: Support dark mode for zoom-image plugin - #2524

Merged
sy-records merged 1 commit into
docsifyjs:developfrom
sy-records:feat/zoom-image
Jan 5, 2025
Merged

sy-records merged 1 commit into
docsifyjs:developfrom
sy-records:feat/zoom-image

Conversation

@sy-records

Copy link
Copy Markdown
Member

Summary

  • Support dark mode for zoom-image plugin.
  • Add z-index, Fix:
image

Related issue, if any:

Fix #2508

What kind of change does this PR introduce?

Feature

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Yes
No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
@sy-records
sy-records requested a review from a team January 3, 2025 06:48
@vercel

vercel Bot commented Jan 3, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 6:49am

@paulhibbitts paulhibbitts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sy-records , this is a fantastic enhancement for the zoom-image plugin, esp. for Docsify v5🙂 I've tested locally and the results look good!

2025-01-03_10-33-08 2025-01-03_10-33-28

Thanks again! Paul

@sy-records
sy-records requested a review from a team January 4, 2025 02:34
Comment thread src/plugins/zoom-image.js Resolved

@Koooooo-7 Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sy-records
sy-records merged commit 5826863 into docsifyjs:develop Jan 5, 2025
@sy-records
sy-records deleted the feat/zoom-image branch January 5, 2025 07:23
@sy-records sy-records mentioned this pull request Jul 17, 2026

This branch was successfully deployed

1 active deployment
Preview — b0e133fa Deployed Jan 3, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants