Skip to content

fix: dev mode hot reload and add sourcemaps - #2402

Merged
Koooooo-7 merged 3 commits into
developfrom
fix-dev-hot-reload
Apr 17, 2024
Merged

Koooooo-7 merged 3 commits into
developfrom
fix-dev-hot-reload

Conversation

@jhildenbiddle

@jhildenbiddle jhildenbiddle commented Apr 11, 2024 •

Copy link
Copy Markdown
Member

Summary

Fixes two development issues:

  1. Hot reload was not working because the docs site was loading lib/docsify.min.js which was only updated on "production" builds. The build now generates minified and non-minified bundles for all builds.
  2. Source maps are now generated for all .min.js files in /lib/. This solution is best for troubleshooting during development because source maps provide unminified source code along with accurate file and line locations on errors. Using non-minified bundles for development was previously discussed, however this approach does not provide accurate source file and line locations.

Related issue, if any:

None

What kind of change does this PR introduce?

Bugfix
Build-related changes

For any code change,

N/A

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
@vercel

vercel Bot commented Apr 11, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 7:20am
@jhildenbiddle jhildenbiddle self-assigned this Apr 11, 2024
@jhildenbiddle jhildenbiddle added this to the 5.x milestone Apr 11, 2024
@jhildenbiddle
jhildenbiddle requested a review from a team April 12, 2024 14:17
Koooooo-7
Koooooo-7 previously approved these changes Apr 13, 2024

@Koooooo-7 Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Koooooo-7
Koooooo-7 requested a review from a team April 13, 2024 04:50
@sy-records
sy-records requested a review from Koooooo-7 April 13, 2024 07:20
@jhildenbiddle

Copy link
Copy Markdown
Member Author

@Koooooo-7 --

Awaiting approval to merge PR. Thx!

@Koooooo-7
Koooooo-7 merged commit 947d8de into develop Apr 17, 2024
@Koooooo-7
Koooooo-7 deleted the fix-dev-hot-reload branch April 17, 2024 03:52
@sy-records sy-records mentioned this pull request Jul 17, 2026

This branch was successfully deployed

1 active deployment
Preview — e0a90ab6 Deployed Apr 13, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants