[hjgraca]

Please provide the issue number

Issue number: #779

Summary

Changes

Add support for Metrics.DefaultDimensions property in static Metrics. This makes it easier to reuse DefaultDimensions in PushSingleMetric. Options.DefaultDimensions for intances of Metrics when using the Builder or Configuration patterns.

User experience

Empty Default dimensions

Metrics.PushSingleMetric("SingleMetric", 1, MetricUnit.Count);

with new Dictionary<string, string>

Metrics.PushSingleMetric("SingleMetric", 1, MetricUnit.Count, resolution: MetricResolution.High,
            dimensions: new Dictionary<string, string> {
                { "Default", "SingleMetric" }
            });

Use existing Default Dimensions

Use Metrics.DefaultDimensions static property

 Metrics.SetDefaultDimensions(new Dictionary<string, string> 
        {
            { "Default", "SingleMetric" }
        });
        Metrics.PushSingleMetric("SingleMetric", 1, MetricUnit.Count, dimensions: Metrics.DefaultDimensions );

Options or Builder patterns

Use Options.DefaultDimensions

    _metrics = new MetricsBuilder()
        .WithDefaultDimensions(new Dictionary<string, string>
        {
            { "Environment", "Prod1" },
            { "Another", "One" }
        }).Build();

_metrics.PushSingleMetric("SuccessfulBooking", 1, MetricUnit.Count, dimensions: _metrics.Options.DefaultDimensions);

Checklist

Please leave checklist items unchecked if they do not apply to your change.

• Meets tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.96%. Comparing base (367d990) to head (ce9bf85).
Report is 12 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #780   +/-   ##
========================================
  Coverage    73.95%   73.96%           
========================================
  Files          210      210           
  Lines         8378     8381    +3     
  Branches       904      904           
========================================
+ Hits          6196     6199    +3     
  Misses        1884     1884           
  Partials       298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud