[hjgraca]

Please provide the issue number

Issue number: #654

Summary

Changes

This pull request includes significant changes to the AWS.Lambda.Powertools.Metrics library, focusing on improving the interface and functionality of the Metrics class and related components. The primary changes involve refactoring the IMetrics interface, enhancing the Metrics class, and updating the MetricsAspect class to support the new configuration approach.

Metrics.Configure

You can now configure Metrics in the constructor, this allows to configure default dimensions and other properties

Testing with dependency injection

With this new model you can finally test Metrics with dependency injection

Builder pattern

You can also create a Metrics instance with Builder pattern. As you can see in the example bellow all properties can be set in the constructor and will be used on the decorated handler.

Interface and Documentation Improvements:

• libraries/src/AWS.Lambda.Powertools.Metrics/IMetrics.cs: Improved documentation for methods and parameters, and updated method signatures to provide default values for parameters.

Configuration and Initialization Enhancements:

• libraries/src/AWS.Lambda.Powertools.Metrics/Metrics.cs: Introduced a new Configure method to set up the Metrics instance with options, and added a static Instance property for easier access. Updated the class to reflect these changes and added new properties and methods to support the configuration options. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Metrics Aspect Refactoring:

• libraries/src/AWS.Lambda.Powertools.Metrics/Internal/MetricsAspect.cs: Updated the Before method to use the new Configure method for setting up the Metrics instance and refactored the cold start metric handling to use the new configuration options. [1] [2]

Minor Code Cleanups:

• libraries/src/AWS.Lambda.Powertools.Metrics/Internal/MetricsAspect.cs: Removed unnecessary using statements.
• libraries/src/AWS.Lambda.Powertools.Metrics/Metrics.cs: Added missing using statements for System.Diagnostics and System.Threading.

These changes collectively improve the flexibility, readability, and maintainability of the AWS.Lambda.Powertools.Metrics library.

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

• Meets tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[codecov]

Codecov Report

Attention: Patch coverage is 86.93467% with 26 lines in your changes missing coverage. Please review.

Project coverage is 73.82%. Comparing base (c99d76b) to head (518b874).
Report is 14 commits behind head on develop.

Files with missing lines	Patch %	Lines
...aries/src/AWS.Lambda.Powertools.Metrics/Metrics.cs	80.91%	18 Missing and 7 partials ⚠️
...ambda.Powertools.Metrics/Internal/MetricsAspect.cs	92.85%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #771      +/-   ##
===========================================
+ Coverage    73.43%   73.82%   +0.38%     
===========================================
  Files          205      205              
  Lines         8323     8324       +1     
  Branches       901      901              
===========================================
+ Hits          6112     6145      +33     
+ Misses        1908     1884      -24     
+ Partials       303      295       -8     

Flag	Coverage Δ
unittests	73.82% <86.93%> (+0.38%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[leandrodamascena]

Hey @hjgraca! Super nice work! I just left a small comment to make the code more clear.