Skip to content

chore: include mermaid in mkdocs config. Fix identation and line numbers idempotency - #400

Merged
hjgraca merged 1 commit into
developfrom
hjgraca-fix-idempotency-docs
Aug 29, 2023
Merged

hjgraca merged 1 commit into
developfrom
hjgraca-fix-idempotency-docs

Conversation

@hjgraca

@hjgraca hjgraca commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

Please provide the issue number

Issue number: #396

Summary

include mermaid in mkdocs config. Fix identation and line numbers idempotency

Changes

Please provide a summary of what's being changed

include mermaid in mkdocs config. Fix identation and line numbers idempotency

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign
auto-assign Bot requested review from amirkaws and sliedig August 29, 2023 12:43
@boring-cyborg boring-cyborg Bot added the documentation Improvements or additions to documentation label Aug 29, 2023
@pull-request-size pull-request-size Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2023
@github-actions github-actions Bot added the internal Maintenance changes label Aug 29, 2023
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter

codecov-commenter commented Aug 29, 2023 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.80%. Comparing base (9ac1226) to head (d1fdb7b).
⚠️ Report is 1590 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #400      +/-   ##
===========================================
- Coverage    72.88%   72.80%   -0.09%     
===========================================
  Files           82       82              
  Lines         3644     3644              
===========================================
- Hits          2656     2653       -3     
- Misses         988      991       +3     
Flag Coverage Δ
unittests 72.80% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amirkaws amirkaws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca
hjgraca merged commit e241ca9 into develop Aug 29, 2023
@hjgraca
hjgraca deleted the hjgraca-fix-idempotency-docs branch August 29, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

3 participants