Skip to content

chore: updated docker builds to use Amazon.Lambda.Tools - #118

Merged
amirkaws merged 2 commits into
aws-powertools:developfrom
sliedig:sliedig/examples
Jul 15, 2022
Merged

amirkaws merged 2 commits into
aws-powertools:developfrom
sliedig:sliedig/examples

Conversation

@sliedig

@sliedig sliedig commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

Updated docker builds for examples

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sliedig
sliedig requested a review from amirkaws March 28, 2022 07:34
@sliedig

sliedig commented Mar 29, 2022 •

Copy link
Copy Markdown
Contributor Author

Going to review the need to include the aws-lambda-tools-defaults.json file for build. Seems to me that this is only really needed when you use Visual Studio. Please hold off on the review.

@amirkaws amirkaws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dockerfile: Dockerfile
DockerBuildArgs:
SAM_BUILD_MODE: Release # Debug or Release
SAM_BUILD_MODE: run # debug or rune

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo run

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it in next PR

@amirkaws
amirkaws merged commit 6f9098f into aws-powertools:develop Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants