Changeset 61796

Timestamp:

03/03/2026 02:59:01 PM (37 hours ago)

Author:

jonsurrell

Message:

HTML API: Check tag namespace in ::set_modifiable_text().

The method should only apply to special "atomic" HTML tags like SCRIPT or TEXTAREA. ::set_modifiable_text() should not apply to tags with the same name in other namespaces.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/11083.

Props jonsurrell, dmsnell, westonruter.
Fixes #64751.

Location:

trunk

Files:

• src/wp-includes/html-api/class-wp-html-tag-processor.php (modified) (1 diff)
• tests/phpunit/tests/html-api/wpHtmlProcessorModifiableText.php (modified) (3 diffs)
• tests/phpunit/tests/html-api/wpHtmlTagProcessorModifiableText.php (modified) (2 diffs)

trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -3818 +3818 @@
         }
 
-        if ( self::STATE_MATCHED_TAG !== $this->parser_state ) {
+        /*
+         * The rest of this function handles modifiable text for special "atomic" HTML elements.
+         * Only tags in the HTML namespace should be processed.
+         */
+        if (
+            self::STATE_MATCHED_TAG !== $this->parser_state ||
+            'html' !== $this->get_namespace()
+        ) {
             return false;
         }

trunk/tests/phpunit/tests/html-api/wpHtmlProcessorModifiableText.php

@@ -25 +25 @@
      * @param string $expected_html    Expected HTML output.
      */
-    public function test_modifiable_text_special_textarea( string $set_text, string $expected_html ) {
+    public function test_modifiable_text_special_textarea( string $set_text, string $expected_html ) {
         $processor = WP_HTML_Processor::create_fragment( '<textarea></textarea>' );
         $processor->next_token();
@@ -51 +51 @@
      * Data provider.
      *
-     * @return array[]
+     * @return array
      */
-    public static function data_modifiable_text_special_textarea() {
+    public static function data_modifiable_text_special_textarea() {
         return array(
             'Leading newline'                   => array(
@@ -69 +69 @@
         );
     }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }

trunk/tests/phpunit/tests/html-api/wpHtmlTagProcessorModifiableText.php

@@ -645 +645 @@
      * @ticket 64609
      */
-    public function test_modifiable_text_special_textarea() {
+    public function test_modifiable_text_special_textarea() {
         $processor = new WP_HTML_Tag_Processor( '<textarea></textarea>' );
         $processor->next_token();
@@ -665 +665 @@
         );
     }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }