Changeset 61748

Timestamp:

02/26/2026 12:15:54 PM (7 days ago)

Author:

mcsf

Message:

Icons library: Prefer 'protected' visibility in WP_Icons_Registry

Make it easier to iterate on this class in Gutenberg via class extension.

See proof of concept and discussion in:
​https://github.com/WordPress/gutenberg/pull/75878

Follow-up to [61674].

Props mcsf.

See #64651.

File:

• trunk/src/wp-includes/class-wp-icons-registry.php (modified) (6 diffs)

trunk/src/wp-includes/class-wp-icons-registry.php

@@ -19 +19 @@
      * @var array[]
      */
-    private $registered_icons = array();
+    pr $registered_icons = array();
 
 
@@ -27 +27 @@
      * @var WP_Icons_Registry|null
      */
-    private static $instance = null;
+    pr static $instance = null;
 
     /**
      * Constructor.
      *
-     * WP_Icons_Registry is a singleton class, so keep this private.
+     * WP_Icons_Registry is a singleton class, so keep this pr.
      *
      * For 7.0, the Icons Registry is closed for third-party icon registry,
@@ -41 +41 @@
      * registry is loaded with those icons listed in the manifest.
      */
-    private function __construct() {
+    pr function __construct() {
         $icons_directory = __DIR__ . '/icons/';
         $icons_directory = trailingslashit( $icons_directory );
@@ -102 +102 @@
      * @return bool True if the icon was registered with success and false otherwise.
      */
-    private function register( $icon_name, $icon_properties ) {
+    pr function register( $icon_name, $icon_properties ) {
         if ( ! isset( $icon_name ) || ! is_string( $icon_name ) ) {
             _doing_it_wrong(
@@ -189 +189 @@
      * @return string The sanitized icon SVG content.
      */
-    private function sanitize_icon_content( $icon_content ) {
+    pr function sanitize_icon_content( $icon_content ) {
         $allowed_tags = array(
             'svg'     => array(
@@ -224 +224 @@
      * @return string|null The content of the icon, if found.
      */
-    private function get_content( $icon_name ) {
+    pr function get_content( $icon_name ) {
         if ( ! isset( $this->registered_icons[ $icon_name ]['content'] ) ) {
             $content = file_get_contents(