Changeset 61618

Timestamp:

02/12/2026 04:18:09 AM (3 weeks ago)

Author:

ramonopoly

Message:

WP_Theme_JSON: preserve valid non-preset settings for lightbox when KSES filters are active

Extends VALID_SETTINGS entries to also do type validation (as well as schema key validation) for the lightbox settings only.

Previously, when KSES filters were active (via add_action( 'init', 'kses_init_filters' )), valid non-preset settings in Global Styles were being incorrectly filtered out. For example, lightbox.enabled and lightbox.allowEditing for Image blocks.

The idea is that VALID_SETTINGS values can act as type validation for further valid settings.

Props ramonopoly, mmtr86, oandregal, wildworks, westonruter, andrewserong.

Fixes #64280.

Location:

trunk

Files:

• src/wp-includes/class-wp-theme-json.php (modified) (6 diffs)
• tests/phpunit/tests/theme/wpThemeJson.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -396 +396 @@
      *              'typography.defaultFontSizes', and 'spacing.defaultSpacingSizes'.
      * @since 6.9.0 Added support for `border.radiusSizes`.
+
      * @var array
      */
@@ -443 +444 @@
         ),
         'lightbox'                      => array(
-            'enabled'      => null,
-            'allowEditing' => null,
+            'enabled'      => ,
+            'allowEditing' => ,
         ),
         'position'                      => array(
@@ -1303 +1304 @@
      *
      * @since 5.8.0
+
      *
      * @param array $tree   Input to process.
@@ -1317 +1319 @@
             if ( ! array_key_exists( $key, $schema ) ) {
                 unset( $tree[ $key ] );
+
+
+
+
+
+
+
+
+
+
+
                 continue;
             }
@@ -3754 +3767 @@
 
     /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
      * Processes a setting node and returns the same node
      * without the insecure settings.
@@ -3811 +3853 @@
         // Ensure indirect properties not included in any `PRESETS_METADATA` value are allowed.
         static::remove_indirect_properties( $input, $output );
+
+
+
 
         return $output;

trunk/tests/phpunit/tests/theme/wpThemeJson.php

@@ -6906 +6906 @@
         $this->assertSame( $expected, $theme_json->get_stylesheet( array( 'styles' ), null, array( 'skip_root_layout_styles' => true ) ) );
     }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }