Changeset 61551

Timestamp:

01/28/2026 10:42:10 PM (5 weeks ago)

Author:

peterwilsoncc

Message:

Feeds: Fix backward compatibility of fetch_feed().

In ​simplepie/simplepie#795 handling of multiple feed requests was deprecated, triggering the message Fetching multiple feeds with single SimplePie instance is deprecated since SimplePie 1.9.0, create one SimplePie instance per feed and use SimplePie::merge_items to get a single list of items.

This updates fetch_feed() to handle multiple requests using seperate SimplePie instances in order to retain backward compatibility.

A PHP 8.5 deprecation was throwing notices in the event an empty URL was passed to fetch_feed(), Using null as an array offset is deprecated, use an empty string instead.

This includes a workaround pending the release of a SimplePie version including ​simplepie/simplepie#949.

Fixes #64136.
Props audrasjb, jorbin, muryam, oglekler, ozgursar, presskopp, swissspidy, westonruter, wildworks, peterwilsoncc.

Location:

trunk

Files:

• src/wp-includes/feed.php (modified) (2 diffs)
• tests/phpunit/tests/feed/fetchFeed.php (modified) (2 diffs)

trunk/src/wp-includes/feed.php

@@ -833 +833 @@
     $feed->get_registry()->register( SimplePie\File::class, 'WP_SimplePie_File', true );
 
-    $feed->set_feed_url( $url );
     /** This filter is documented in wp-includes/class-wp-feed-cache-transient.php */
     $feed->set_cache_duration( apply_filters( 'wp_feed_cache_transient_lifetime', 12 * HOUR_IN_SECONDS, $url ) );
@@ -847 +846 @@
     do_action_ref_array( 'wp_feed_options', array( &$feed, $url ) );
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
     $feed->init();
     $feed->set_output_encoding( get_bloginfo( 'charset' ) );

trunk/tests/phpunit/tests/feed/fetchFeed.php

@@ -35 +35 @@
 
     /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
      * Ensure that fetch_feed() is cached on second and subsequent calls.
      *
@@ -112 +215 @@
         );
     }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }