Bug 1755647 - Fire change event on window.screen.orientation. r=nchevobbe.
AbandonedPublic

Authored by rubicon on Nov 27 2024, 5:19 PM.
Referenced Files
Unknown Object (File)
Tue, Aug 11, 2:10 PM
Unknown Object (File)
Jul 13 2026, 10:09 PM
Unknown Object (File)
Jul 12 2026, 10:32 PM
Unknown Object (File)
Jul 12 2026, 10:32 PM
Unknown Object (File)
Jul 9 2026, 6:29 PM
Unknown Object (File)
Jul 2 2026, 9:38 AM
Unknown Object (File)
Jun 7 2026, 9:34 AM
Unknown Object (File)
Jun 7 2026, 7:28 AM
Subscribers
None

Details

Reviewers
nchevobbe
Group Reviewers
devtools-reviewers
Bugzilla Bug ID
1755647
Summary

The change event is fired in ResponseActor.dispatchOrientationChangeEvent, along side the orientationchange event.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Thanks, that looks good. Do you think you could fold this patch directly in D230266: Bug 1755647 - Fire change event on window.screen.orientation. r=nchevobbe. ? We usually prefer having the tests in the same patch as the fix/new feature

This revision is now accepted and ready to land.Nov 29 2024, 7:05 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

rubicon retitled this revision from Bug 1755647: Test for firing screen orientation change event. r=nchevobbe to Bug 1755647 - Fire change event on window.screen.orientation. r=nchevobbe..
rubicon edited the summary of this revision. (Show Details)
This comment was removed by rubicon.

I finally figured out how to do this. The content of this rev is now merged to D230266 :)

I finally figured out how to do this. The content of this rev is now merged to D230266 :)

perfect, thanks!