Closed
Bug 2008109
Opened 2 months ago
Closed 2 months ago
Cumulative Layout Shift (CLS) on directory listing page due to missing image dimensions
Categories
(Core :: Networking, enhancement)
Tracking
()
RESOLVED
FIXED
148 Branch
| Tracking | Status | |
|---|---|---|
| firefox148 | --- | fixed |
People
(Reporter: ethan, Assigned: ethan)
Details
Attachments
(2 files)
|
29.12 KB,
image/webp
|
Details | |
|
Bug 2008109 - Add explicit dimensions to directory listing icons to prevent layout shift. r?valentin
48 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:147.0) Gecko/20100101 Firefox/147.0
Steps to reproduce:
Load the page on a directory listing page (file://path/to/directory).
Actual results:
There is a layout shift that occurs whilst the images are being rendered. This is especially noticable if the page is reloaded or force reloaded. This is due to the images having a max-width and max-height set, rather than a width and height.
Expected results:
There should be no layout shift, as the images should have their space reserved by the browser whilst they are being rendered.
| Assignee | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Assignee: nobody → ethan
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•2 months ago
|
Component: Untriaged → Networking
Product: Firefox → Core
Pushed by kjang@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8254d9011bc7
https://hg.mozilla.org/integration/autoland/rev/1879db52bff1
Add explicit dimensions to directory listing icons to prevent layout shift. r=valentin,necko-reviewers
Comment 3•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
Updated•1 month ago
|
QA Whiteboard: [qa-ver-opt-c149/b148][qa-triage-done-c149/b148]
You need to log in
before you can comment on or make changes to this bug.
Description
•